feat 97 메모 수정기능 추가 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj0526
reviewed
Aug 6, 2025
| updated = true; | ||
| } | ||
|
|
||
| if (request.file() != null) { |
Collaborator
There was a problem hiding this comment.
updated = true;로 값이 수정이 안되는 부분도 있네요 확인부탁드려요
Collaborator
There was a problem hiding this comment.
또한 해당 메소드 마지막에 있는 updated 값이 false일 때 커스텀 예외처리 부탁드립니다
jj0526
requested changes
Aug 6, 2025
| BOOKMARK_TAG_MINIMUM_REQUIRED_EXCEPTION(400, "최소 1개 이상의 태그를 선택해야 합니다."), | ||
| BOOKMARK_TAG_COUNT_EXCEEDED_EXCEPTION(400, "태그는 최대 3개까지만 선택할 수 있습니다."); | ||
| BOOKMARK_TAG_COUNT_EXCEEDED_EXCEPTION(400, "태그는 최대 3개까지만 선택할 수 있습니다."), | ||
| Bookmark_Update_Field_Empty_Exception(400, "업데이트할 필드가 존재하지 않습니다."); |
Comment on lines
222
to
224
| NotificationSaveRequest saveRequest = new NotificationSaveRequest( | ||
| request.notification().notifyAt() | ||
| ); |
| if (request.url() != null && !request.url().trim().isEmpty()) { | ||
| bookmark.updateUrl(request.url()); | ||
| updated = true; | ||
| } |
Collaborator
There was a problem hiding this comment.
thumbnailUrl, platform, faviconUrl, url은 모두 url이 바뀌었기에 일어나기에 검증 처리를 통해 한번에 이루어져야 한다고 생각됩니다. 하지만 시간상 이후에 리팩토링으로 부탁드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 관련 이슈
🔎 작업 내용
📷 이미지 첨부
✅ Check List